Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: host builder nonregular file support #2156

Merged
merged 12 commits into from
Feb 20, 2024
Merged

feat: host builder nonregular file support #2156

merged 12 commits into from
Feb 20, 2024

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented Feb 12, 2024 •
edited
Loading

Changes

  • 🎁 Host builder nonregular file support (ex: symlinks)

/kind enhancement

Fixes #

Release Note

The prototype host builder now supports nonregular files such as symlinks

Docs

@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 12, 2024

@lkingland: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🎁 Host builder nonregular file support (ex: symlinks)

/kind

Fixes #

Release Note

The prototype host builder now supports nonregular files such as symlinks

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2024
@lkingland lkingland changed the title Host builder nonregular file support feat: host builder nonregular file support Feb 12, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 12, 2024 •
edited
Loading

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (c252c4f) 64.21% compared to head (ed15d98) 65.05%.
Report is 28 commits behind head on main.

❗ Current head ed15d98 differs from pull request most recent head 17c097d. Consider uploading reports for the commit 17c097d to get more accurate results

Files Patch % Lines
pkg/oci/containerize.go 23.07% 16 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2156      +/-   ##
==========================================
+ Coverage   64.21%   65.05%   +0.84%     
==========================================
  Files         108      108              
  Lines       13919    13940      +21     
==========================================
+ Hits         8938     9069     +131     
+ Misses       4108     3968     -140     
- Partials      873      903      +30
Flag Coverage Δ
e2e-test 37.31% <0.00%> (-0.06%) ⬇️
e2e-test-oncluster 30.49% <0.00%> (-0.10%) ⬇️
e2e-test-oncluster-runtime 26.78% <0.00%> (?)
e2e-test-runtime-go 25.51% <0.00%> (?)
e2e-test-runtime-node 26.53% <0.00%> (?)
e2e-test-runtime-python 26.53% <0.00%> (?)
e2e-test-runtime-quarkus 26.64% <0.00%> (?)
e2e-test-runtime-rust 25.54% <0.00%> (?)
e2e-test-runtime-springboot 25.67% <0.00%> (?)
e2e-test-runtime-typescript 26.64% <0.00%> (?)
integration-tests 51.77% <23.07%> (+1.95%) ⬆️
unit-tests-macos-latest 48.76% <23.07%> (-0.10%) ⬇️
unit-tests-ubuntu-latest 49.52% <23.07%> (?)
unit-tests-windows-latest 48.83% <23.07%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkingland lkingland force-pushed the host-builder-nonregular branch from a9687cf to 6e44cac Compare February 12, 2024 12:02
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2024
matejvasek
matejvasek reviewed Feb 12, 2024
View reviewed changes
pkg/oci/containerize.go Outdated Show resolved Hide resolved
@matejvasek
Copy link
Contributor

Would it be possible to add some test?

@matejvasek matejvasek requested review from matzew and gauron99 and removed request for navidshaikh and vyasgun February 12, 2024 13:39
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 13, 2024
@lkingland lkingland force-pushed the host-builder-nonregular branch from ebe56f1 to 83a8e2f Compare February 13, 2024 06:54
@lkingland lkingland force-pushed the host-builder-nonregular branch from 83a8e2f to be43ac3 Compare February 13, 2024 12:49
matejvasek
matejvasek reviewed Feb 14, 2024
View reviewed changes
pkg/oci/containerize.go Outdated Show resolved Hide resolved
matejvasek
matejvasek reviewed Feb 14, 2024
View reviewed changes
pkg/oci/containerize.go Outdated Show resolved Hide resolved
@matejvasek
Copy link
Contributor

We already have some complex test here:

func/pkg/oci/builder_test.go

Line 30 in 24fe6d3

func TestBuilder_Build(t *testing.T) {

Please consider adding symlink there.

@lkingland lkingland force-pushed the host-builder-nonregular branch from c7623ba to ed15d98 Compare February 14, 2024 04:28
matejvasek
matejvasek reviewed Feb 14, 2024
View reviewed changes
pkg/oci/containerize.go Outdated Show resolved Hide resolved
@knative-prow knative-prow bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 16, 2024
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 16, 2024
matejvasek
matejvasek reviewed Feb 16, 2024
View reviewed changes
pkg/oci/containerize.go Outdated Show resolved Hide resolved
matejvasek
matejvasek reviewed Feb 16, 2024
View reviewed changes
pkg/oci/containerize.go Outdated Show resolved Hide resolved
@lkingland lkingland force-pushed the host-builder-nonregular branch from f9cd1e2 to da57b32 Compare February 16, 2024 05:18
@lkingland
refactor
a0022b2 
Resolve the link target one level higher such that it can be used
when creating the tar header without repetition.
@lkingland
validate link header targets
71b5887
@lkingland
expand link test
1bdd09b
@lkingland lkingland force-pushed the host-builder-nonregular branch from e08720f to d496fa8 Compare February 19, 2024 04:28
@lkingland lkingland force-pushed the host-builder-nonregular branch from d496fa8 to d09d5be Compare February 19, 2024 04:44
matejvasek
matejvasek reviewed Feb 19, 2024
View reviewed changes
pkg/oci/containerize.go Outdated Show resolved Hide resolved
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9ca1b6d into knative:main Feb 20, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejvasek matejvasek matejvasek left review comments

@matzew matzew Awaiting requested review from matzew

@gauron99 gauron99 Awaiting requested review from gauron99

Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkingland @matejvasek